-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BYOC][ACL] Depthwise convolution support #7206
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added support for depthwise convolution. ACL only supports depth-wise convolution when kernel size is 3x3 and 5x5 and strides are (1, 1) or (2, 2), if this is not the case then fallback to TVM. Also rework tests to remove non-deterministic trials. *Compute Library for the Arm Architecture (ACL). *All credits to Luke Hutton @lhutton1 Change-Id: Ida1f5802a65377b84325edf14a0149242c1af857
2948252
to
f02e26e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the delay, just one small thing I missed previously, otherwise looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM too.
Thanks @d-smirnov @lhutton1 ! This is now merged. |
* [BYOC][ACL] Depthwise convolution support Added support for depthwise convolution. ACL only supports depth-wise convolution when kernel size is 3x3 and 5x5 and strides are (1, 1) or (2, 2), if this is not the case then fallback to TVM. Also rework tests to remove non-deterministic trials. *Compute Library for the Arm Architecture (ACL). *All credits to Luke Hutton @lhutton1 Change-Id: Ida1f5802a65377b84325edf14a0149242c1af857 * linter * CHECK -> ICHECK Co-authored-by: Luke Hutton <[email protected]>
* [BYOC][ACL] Depthwise convolution support Added support for depthwise convolution. ACL only supports depth-wise convolution when kernel size is 3x3 and 5x5 and strides are (1, 1) or (2, 2), if this is not the case then fallback to TVM. Also rework tests to remove non-deterministic trials. *Compute Library for the Arm Architecture (ACL). *All credits to Luke Hutton @lhutton1 Change-Id: Ida1f5802a65377b84325edf14a0149242c1af857 * linter * CHECK -> ICHECK Co-authored-by: Luke Hutton <[email protected]>
* [BYOC][ACL] Depthwise convolution support Added support for depthwise convolution. ACL only supports depth-wise convolution when kernel size is 3x3 and 5x5 and strides are (1, 1) or (2, 2), if this is not the case then fallback to TVM. Also rework tests to remove non-deterministic trials. *Compute Library for the Arm Architecture (ACL). *All credits to Luke Hutton @lhutton1 Change-Id: Ida1f5802a65377b84325edf14a0149242c1af857 * linter * CHECK -> ICHECK Co-authored-by: Luke Hutton <[email protected]>
* [BYOC][ACL] Depthwise convolution support Added support for depthwise convolution. ACL only supports depth-wise convolution when kernel size is 3x3 and 5x5 and strides are (1, 1) or (2, 2), if this is not the case then fallback to TVM. Also rework tests to remove non-deterministic trials. *Compute Library for the Arm Architecture (ACL). *All credits to Luke Hutton @lhutton1 Change-Id: Ida1f5802a65377b84325edf14a0149242c1af857 * linter * CHECK -> ICHECK Co-authored-by: Luke Hutton <[email protected]>
* [BYOC][ACL] Depthwise convolution support Added support for depthwise convolution. ACL only supports depth-wise convolution when kernel size is 3x3 and 5x5 and strides are (1, 1) or (2, 2), if this is not the case then fallback to TVM. Also rework tests to remove non-deterministic trials. *Compute Library for the Arm Architecture (ACL). *All credits to Luke Hutton @lhutton1 Change-Id: Ida1f5802a65377b84325edf14a0149242c1af857 * linter * CHECK -> ICHECK Co-authored-by: Luke Hutton <[email protected]>
* [BYOC][ACL] Depthwise convolution support Added support for depthwise convolution. ACL only supports depth-wise convolution when kernel size is 3x3 and 5x5 and strides are (1, 1) or (2, 2), if this is not the case then fallback to TVM. Also rework tests to remove non-deterministic trials. *Compute Library for the Arm Architecture (ACL). *All credits to Luke Hutton @lhutton1 Change-Id: Ida1f5802a65377b84325edf14a0149242c1af857 * linter * CHECK -> ICHECK Co-authored-by: Luke Hutton <[email protected]>
Added support for depthwise convolution. ACL only supports depth-wise convolution when kernel size is 3x3 and 5x5 and strides are (1, 1) or (2, 2), if this is not the case then fallback to TVM.
Also rework tests to remove non-deterministic trials.